MAINT: avoid relying on np.generic.__name__ in np.dtype.name
#12205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fails with: Does this test make any sense? |
charris
reviewed
Nov 1, 2018
numpy/core/_dtype.py
Outdated
| # handle bool_, str_, etc | ||
| if name[-1] == '_': | ||
| name = name[:-1] | ||
| name = _kind_name(dtype) |
There was a problem hiding this comment.
I assume this change is responsible for the test failure. I assume that the _kind_name of a derived class is the same as the base class, which makes sense, so the question is whether to use the type.__name__ instead. I think that makes some sense, it seems it would be more informative anyway. More input from others would be helpful.
`dtype.name` is documented as returning a "bit name" - however, we don't want to force `__name__` to be a bit name, as this creates confusing collisions in the repr of the scalar types.
a5dd56a to
d58576a
Compare
|
I no longer remember why I abandoned this, test hopefully now fixed. |
|
Tests pass. No new tests needed? |
|
No behavior change here, this was just a refactor needed for 10151, where I plan to change the name attribute. |
|
Thanks for this piece of the puzzle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dtype.nameis documented as returning a "bit name" - however, we don't want to force__name__to be a bit name, as this creates confusing collisions in the repr of the scalar types.This should be the last refactor needed to get #10151 in.