Skip to content

WIP: use the decorator library for array_function_dispatch #12226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

WIP: use the decorator library for array_function_dispatch #12226

wants to merge 2 commits into from

Conversation

shoyer
Copy link
Member

@shoyer shoyer commented Oct 20, 2018

xref #12028

This is one possible solution for #12225. It fixes introspection for NumPy functions, e.g., we now see

In [3]: inspect.getfullargspec(np.sum)
Out[3]: FullArgSpec(args=['a', 'axis', 'dtype', 'out', 'keepdims'], varargs=None, varkw=None, defaults=(None, None, None, <class 'numpy._globals._NoValue'>), kwonlyargs=[], kwonlydefaults=None, annotations={})

@shoyer shoyer mentioned this pull request Oct 20, 2018
Closed
33 tasks
@eric-wieser
Copy link
Member

#6103 has some discussion about vendoring vs adding dependencies on other packages.

@shoyer shoyer mentioned this pull request Oct 20, 2018
Closed
@shoyer
Copy link
Member Author

shoyer commented Oct 22, 2018

#6103 has some discussion about vendoring vs adding dependencies on other packages.

Yes, I think I would definitely vendor this if needed. But my current inclination is to abandon this approach instead.

@shoyer shoyer closed this Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shoyer @eric-wieser