Skip to content

ENH: override support for np.linspace and friends #12471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2018
Merged

ENH: override support for np.linspace and friends #12471

merged 1 commit into from
Dec 1, 2018

Conversation

shoyer
Copy link
Member

@shoyer shoyer commented Dec 1, 2018 •
edited
Loading

Fixes gh-12379

This doesn't support overrides in np.arange() (since it's less clear that makes sense)

Note that potentially we should wait until #12388 goes in before merging this.

@shoyer shoyer mentioned this pull request Dec 1, 2018
Merged
mhvk
mhvk approved these changes Dec 1, 2018
View reviewed changes
Copy link
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Not sure that order matters too much.

@shoyer shoyer merged commit 12922e2 into numpy:master Dec 1, 2018
@shoyer shoyer deleted the linspace-overrides branch December 1, 2018 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhvk mhvk mhvk approved these changes

Assignees
No one assigned
Labels
01 - Enhancement component: __array_function__
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shoyer @mhvk