Ticket 1236 suggested fix. #127
Conversation
…nt for structured arrays - it may be nice to be able to add a manual header, too
… keyword arguments of savetxt
|
How do you like those changes? I wrote some tests as well as made the default commentstr='# ' which loadtxt should recognize automagically. |
| @@ -853,6 +854,13 @@ def savetxt(fname, X, fmt='%.18e', delimiter=' ', newline='\n'): | |||
| Character separating columns. | |||
| newline : str | |||
There was a problem hiding this comment.
All the variables with default values need "optional" appended to the type like so:
newline : str, optional
|
Looking good, the tests help. I'm trying to think of a better name than 'commentstr', but not having much luck ;) |
| footer : str | ||
| String that will be written to the end of the file. | ||
| commentstr : str | ||
| String that will be prepended to the ``header`` and ``footer`` strings. |
There was a problem hiding this comment.
Should expand this a bit for clarity, say by adding "...to mark them as comment lines.."
There was a problem hiding this comment.
Changing "commentstr" to "comments" to make it consistent with loadtxt documentation.
…to "comments", to be in line with loadtxt documentation. cleaned up some documentation. Added code to deal with the possibility of header and footer containing newlines, where the "comments" string will be prepended to each line.
|
Looks good. Needs the ".. versionadded:: 2.0.0" bit for the new parameters. I apologize for not noticing that earlier. The '2.0.0' is probably going to be wrong, but we can grep and change it when the time comes for the next release. |
|
I saw that and didn't want to add something in case I was wrong about the numbers. I'll put it in. On 15. aug. 2011, at 16.42, charris wrote:
|
|
I ws thinking something like converting a file from a measurement setup, or a simulation, where you may have a long autogenerated string and it will be slightly more messy to insert comment characters at the correct places. Here savetxt will do it for you. Not that it is a huge issue either way... On 16. aug. 2011, at 03:44, charrisreply@reply.github.com wrote:
|
test: Add testing tools and debugging tools
Ticket 1236 suggested fix. I suggest giving a separate keyword argument for structured arrays - it may be nice to be able to add a manual header, too