MAINT: Change the order of checking for locale file and import urllib modules #12762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and importing urllib modules in numpy._datasource.py to prevent the import in case the local file was found See #12536
|
LGTM. Did this actually fix your problem? Why was the _socket object/module missing? |
|
Thanks @EelcoPeacs . |
|
I notice that your commit message is badly formed. All lines in the message should be < 72 characters in length and separated by line breaks, with a blank line after the summary line at the top. There should be a plugin for your editor that does that for you. |
|
Thanks for the merge. Yes, this fix solved my problem and is also a minor improvement on the sequence of the code for checking file existence. I encountered the problem in a program that incorporates a dedicated build of Python, Seg3D. This special build does not incorporate all libraries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENH: Changed the sequence of checking for locale existence of a file and importing urllib modules in numpy._datasource.py to prevent the import in case the local file was found
See #12536