BUG: Do not crash on recursive .dtype attribute lookup.
#13003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
Feb 21, 2019
eric-wieser
reviewed
Feb 21, 2019
eric-wieser
reviewed
Feb 21, 2019
eric-wieser
reviewed
Feb 21, 2019
eric-wieser
reviewed
Feb 21, 2019
fdbab42 to
2aa6521
Compare
eric-wieser
reviewed
Feb 24, 2019
eric-wieser
reviewed
Feb 24, 2019
| new->names = conv->names; | ||
| Py_INCREF(new->names); | ||
| Py_XINCREF(new->names); |
There was a problem hiding this comment.
Yes, although it might be that the bug it fixes is in paths that normal code should not reach.
|
Generally looks good. Perhaps you should split the deprecation into a separate PR - I think this is close to being ready, but with the deprecation in place it would maybe need to hit the mailing list. Would be a shame to block the bug fix on that. |
2aa6521 to
a80e323
Compare
|
Split off the deprecation (and that funny maintanence of the tests) into gh-13578. |
a80e323 to
929910b
Compare
mattip
reviewed
May 26, 2019
The code path in scalarapi.c which checks dtype on one inheriting from np.void is especially awkward and was completely untested previously. So I am not sure we should even support it at all. Closes numpygh-12982, numpygh-3614, and numpygh-12751
929910b to
65da904
Compare
|
@eric-wieser any more review comments? |
|
As an error is better than a segfault, thanks @seberg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code path in scalarapi.c which checks dtype on one inheriting
from np.void is especially awkward and was completely untested
previously. So I am not sure we should even support it at all.
Closes gh-12982, gh-3614, and gh-12751
Frankly, I am not sure it is actually worth the trouble, but had started on it. The actual error message does not always include the custom message, this seems because the recursion error can also be triggered by the
GetAttrcall (at least when dtype is made a property).If we attack dtypes in any case, I am afraid adding more band-aids will just make things harder in the long run anyway.