-
-
Notifications
You must be signed in to change notification settings - Fork 11k
DOC: add missing routines to reference guide #13214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When I |
The docstrings come from numpy, so you need to install the latest version of numpy into the python3.6 that is used to build documentation. The directions say "Note that you can eg. install NumPy to a temporary location and set the PYTHONPATH environment variable appropriately.". Another way is to run python3.6 in a virtual environment, then you can call |
You can also run |
xref #12385 |
If you add items to your checklist, please be sure they do not appear in #13222 |
Thank you! This helped me set up the virtualenv and install numpy in that. I ran |
Can you clarify what you mean by "no luck with the autosummary"? Do you mean that changes you make to docstrings do not show up in the html you view after a build? Are you cleaning out the relevant files so they are regenerated (one way to do that is |
I'm sorry, I wasn't clear. |
Looking at the documentation as built in CI everything looks fine. There is a line now under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now.
I do wonder if we should deprecate that function (in a separate issue). It looks to be a weird dispatcher between np.equal
and np.char.equal
(and the other 5 operators)
Yes, you need to change the Once you change the We have a special syntax for adding a |
I think I would prefer to put |
Would be +1 for disp deprecation. Since |
+1 on deprecating |
|
All deprecations that were part of the public API need a few versions before actual removal. |
|
||
get_include | ||
|
||
Deprecation warning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a huge fan of this title, but I guess better than not having any reference at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had initially thought of Warning Generator for the title here, but that seemed ambiguous. It may not be intuitive for a beginner looking for deprecate
. What are we looking for in a good title?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is Handling Old Functions in NumPy for the title?
The azure-pipeline errors are because I did not change the test_io.py. If not, I will instead improve their documentation. |
Closing, replaced by #13847 |
These have their relevant docstrings. I'll add them to the reference guide.
'compare_chararrays': 'numpy.core._multiarray_umath.compare_chararrays',
'add_newdoc': 'numpy.core.function_base.add_newdoc',
'byte_bounds': 'numpy.lib.utils.byte_bounds',
'deprecate': 'numpy.lib.utils.deprecate',
'get_include': 'numpy.lib.utils.get_include',
'who': 'numpy.lib.utils.who',
To Deprecate:
'disp': 'numpy.lib.function_base.disp',
'recfromcsv': 'numpy.lib.npyio.recfromcsv',
'recfromtxt': 'numpy.lib.npyio.recfromtxt',
'safe_eval': 'numpy.lib.utils.safe_eval'
'Tester': 'numpy.testing._private.nosetester.NoseTester',