MAINT: Move asarray helpers into their own module #13324
Conversation
| from .multiarray import array | ||
|
|
||
|
|
||
| __all__ = [ |
There was a problem hiding this comment.
I still prefer normal lists fromatting for this. This sort of works for a few entries, but I don't think it buys much over the usual left to right reading habit.
There was a problem hiding this comment.
This sort of works for a few entries
That's a feature, it discourages too many items from being put in a single module ;)
|
LGTM, but I hope you aren't going to make a habit of the vertical |
|
So you mean, don't try to pull #9453 again? Sure, I can change this and the other PR to put them on one line |
This is a direct move, with some tweaks to imports. This breaks a cyclic imports between `core.numeric` and `core.fromnumeric`. This doesn't affect the value of `np.core.numeric.__all__` which keeps code doing `from numpy.core.numeric import *` working.
73d7bab to
82641c6
Compare
Just so :) I admit it is easier to alphabetize the vertical lists -- I convert back and forth when doing that -- but If it isn't too much bother I would prefer the usual. |
|
I think logical grouping is probably more valuable than alphabetizing anyway. I had a look through cpython for precedent, and the style is pretty mixed. Once this goes in, I'll rebase #13322 and collapse the |
|
Looks like this caught the LGTM alerts already - I was expecting to have to merge the other PR for that to work... |
|
Thanks Eric. |
This is a direct move, with some tweaks to imports.
This breaks a cyclic imports between
core.numericandcore.fromnumeric.This doesn't affect the value of
np.core.numeric.__all__which keeps code doingfrom numpy.core.numeric import *working.Similar to #13322