ENH: implement __skip_array_function__ attribute for NEP-18
#13389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
247f88b to
afda748
Compare
__skip_array_function__ attribute for NEP-18
33 tasks
|
Can remove the draft status after NEP changes are accepted? |
Yes, will do |
|
@shoyer was the work to change |
mattip
reviewed
May 13, 2019
| @@ -152,6 +152,8 @@ def public_api(*args, **kwargs): | |||
| if module is not None: | |||
| public_api.__module__ = module | |||
|
|
|||
| public_api.__skip_array_function__ = implementation | |||
|
|
|||
| return public_api | |||
There was a problem hiding this comment.
This will not merge cleanly after #13529
|
This is ready for review |
|
LGTM |
|
Anyone else want to take a look? Otherwise I'll merge this tomorrow. I have a few small changes building on top of this that I want to get into NumPy 1.17. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To clarify the implications of #13305