BUG: (py2 only) fix unicode support for savetxt fmt string #13409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By now, all that is needed is to also allow unicode strings to pass through. Adds a test for the support which already succeeds on python3. Closes numpygh-4053 (replaces the old PR)
|
Thanks @seberg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By now, all that is needed is to also allow unicode strings to
pass through. Adds a test for the support which already succeeds
on python3.
Closes gh-4053 (replaces the old PR)
This is to Replace the mentioned PR gh-4053, adds a test, otherwise only relevant for python 2, so probably should backport.