Skip to content

MAINT: revert __skip_array_function__ from NEP-18 #13627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 28, 2019
Merged

MAINT: revert __skip_array_function__ from NEP-18 #13627

merged 3 commits into from
May 28, 2019

Conversation

shoyer
Copy link
Member

@shoyer shoyer commented May 25, 2019 •
edited
Loading

xref GH-13624, GH-12028

TODO: update tests/CI for NUMPY_EXPERIMENTAL_ARRAY_FUNCTION=0

@shoyer
MAINT: revert __skip_array_function__ from NEP-18
766281d 
xref numpyGH-13624, numpyGH-12028

TODO: update tests/CI for NUMPY_EXPERIMENTAL_ARRAY_FUNCTION=0
@shoyer shoyer mentioned this pull request May 25, 2019
Merged
mhvk
mhvk approved these changes May 25, 2019
View reviewed changes
Copy link
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also looks good. I wondered a bit about even defining _implementation when things are not enabled, but in the end it is probably best to have minimal differences.

@shoyer
Copy link
Member Author

shoyer commented May 25, 2019

I wondered a bit about even defining _implementation when things are not enabled, but in the end it is probably best to have minimal differences.

I think we will need this for a few functions that access the implementation internally... we'll see when I run tests with NUMPY_EXPERIMENTAL_ARRAY_FUNCTION=0

@shoyer
Copy link
Member Author

shoyer commented May 25, 2019

I wondered a bit about even defining _implementation when things are not enabled, but in the end it is probably best to have minimal differences.

This actually doesn't work if the function is written in C, so I've removed it (that's why you write tests, I suppose!)

shoyer
shoyer commented May 25, 2019
View reviewed changes
.travis.yml
@@ -64,6 +64,8 @@ matrix:
env: NPY_RELAXED_STRIDES_CHECKING=0
- python: 3.6
env: USE_WHEEL=1 NPY_RELAXED_STRIDES_DEBUG=1
- python: 3.6
env: NUMPY_EXPERIMENTAL_ARRAY_FUNCTION=0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consolidate this CI run into one of the others?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We get 5 parallel runs and we are already over 10, so as long as there are fewer than 15 test runs it shouldn't make much difference. The runs vary in time, so it isn't possible to predict exactly what will happen, but close enough.

@shoyer
Copy link
Member Author

shoyer commented May 26, 2019

OK, tests with array function disabled are passing now.

@charris charris added this to the 1.17.0 release milestone May 28, 2019
@mattip mattip merged commit ab439ec into numpy:master May 28, 2019
This was referenced Jun 7, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charris charris charris left review comments

@mhvk mhvk mhvk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shoyer @charris @mhvk @mattip