I think examples would be nice. We should also standardize the Defalt is ... stanza, altough the nupydoc guide doesn't give clear guidance to what is the One Best Way. Maybe it appears somewhere else?

We should implement the deprecation warning as in #13421, and add the examples from there.

The test I have commented out is the one which fails due to Attribute error: type object tuple has no attribute shape. I am not sure what should be done for this case. In my opinion, it would be too naive to add a condition in the if statement for passing one test. Instead we can modify the test in a way that it does not contain the commented out line and instead write deprecation tests for checking the behavior when fill_value is non-scalar non-broadcastable. Let me know what would be better.

@seberg when I added a check like

if((np.isscalar(fill_value) == True) or (ndtype.shape == fill_value.shape)):
return np.array(fill_value)
else:
err_msg = "Cannot find valid fill_value for dtype %s"
raise TypeError(err_msg % ndtype)

at the end of the _check_fill_value, around 18 tests are failing, logs of which are present here Am I missing something?

Release note needed for the new deprecation

This looks almost ready, just need to add a 1.18.0 version number to the deprecation, and a release note.

Thanks @kritisingh1