DOC: Mention and try to explain pairwise summation in sum #13737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this behavour is of course inherited into `np.add.reduce` and many other reductions such as `mean` or users of this reduction, such as `cov`. This is ignored here. Closes numpygh-11331, numpygh-9393, numpygh-13734
eric-wieser
reviewed
Jun 8, 2019
|
Thanks! There's a good chance I wouldn't have opened #13734 if I had found this explanation on the page for the |
mhvk
reviewed
Jun 8, 2019
| is only used when the summation is along the fast axis in memory. | ||
| Note that the exact precision may vary depending on other parameters. | ||
| In contrast to NumPy, Python's ``math.fsum`` function uses a slower but | ||
| more precise approach to summation. |
There was a problem hiding this comment.
Is it worth adding that for lower-precision floats such as f4, one can pass in dtype='f8' to increase precision?
There was a problem hiding this comment.
I guess so, although it is growing so long... Maybe the real solution would be to have a longer paragraph about floating point rounding in the user guide and link that...
This was referenced Jun 11, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this behavour is of course inherited into
np.add.reduceandmany other reductions such as
meanor users of this reduction, suchas
cov. This is ignored here.Closes gh-11331, gh-9393, gh-13734
To be honest, not sure I am too happy with it, but it is one of those things that comes up every couple of months.