Fix segfault when PyArray_VOID and no minitype in _array_find_type. #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The patch doesn't apply. You need to do your work in a branch, not in master. And you need to keep master current. |
|
I went ahead and hand applied it. I'm not sure why the patch from github didn't work, but you should never do work in the master branch, always use a working branch. |
|
This was on a branch "fix_np_lookfor_segv" (https://github.com/walshb/numpy/tree/fix_np_lookfor_segv), but the branch was indeed taken from an older version of master. Thanks for applying it, anyway. |
luyahan
pushed a commit
to plctlab/numpy
that referenced
this pull request
Apr 25, 2024
test: Simplify tests with macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for http://www.mail-archive.com/numpy-discussion@scipy.org/msg33130.html.
Sorry!
Ben