Added 'prescan' option to loadtxt for array allocation prior to reading #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting 'prescan=True' will parse the valid data lines of the input file in a first pass, then allocate an array to read the data directly into (row by row), bypassing the creation of an input list with the associated high memory usage.
|
I think this is not the correct approach (will not work with streams etc.). A cleaner one would be
|
|
Looks like it is time to close this. |
luyahan
pushed a commit
to plctlab/numpy
that referenced
this pull request
Apr 25, 2024
feat: Add vshr_n_s8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENH: implement 2-pass reading in loadtxt to avoid problems with
excessive memory usage on large data files. The extra parsing
typically takes 10% of the total read-in time; 30-50% for compressed
files.
Setting 'prescan=True' will parse the valid data lines of the input
file in a first pass, then allocate an array to read the data directly
into (row by row), bypassing the creation of an input list with the
associated high memory usage.