BUG: random: Revert gh-14458 and refix gh-14557. #14490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
Sep 12, 2019
| @@ -3517,7 +3517,7 @@ cdef class RandomState: | |||
| # Convert to int64, if necessary, to use int64 infrastructure | |||
| ongood = ongood.astype(np.int64) | |||
| onbad = onbad.astype(np.int64) | |||
| onbad = onbad.astype(np.int64) | |||
| onsample = onsample.astype(np.int64) | |||
eric-wieser
reviewed
Sep 12, 2019
| onsample = <np.ndarray>np.PyArray_FROM_OTF(nsample, np.NPY_INT64, np.NPY_ALIGNED) | ||
| ongood = <np.ndarray>np.PyArray_FROM_OTF(ngood, np.NPY_LONG, np.NPY_ALIGNED) | ||
| onbad = <np.ndarray>np.PyArray_FROM_OTF(nbad, np.NPY_LONG, np.NPY_ALIGNED) | ||
| onsample = <np.ndarray>np.PyArray_FROM_OTF(nsample, np.NPY_LONG, np.NPY_ALIGNED) |
There was a problem hiding this comment.
Can you remind me why we're using long here instead of int64?
There was a problem hiding this comment.
Legacy. The original random code was written using C long integers. This code is supposed to preserve the old behavior.
|
Thanks Warren. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts gh-14458 and instead fixes the actual incorrect code.
This fixes a regression in 1.17 and does not result in a change in behavior of the legacy random code.