BLD: add warn-error option, adds -Werror to compiler #14527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This relates to build enhancements in #14518 which hides the compiler output from |
rgommers
reviewed
Sep 16, 2019
| @@ -106,6 +106,8 @@ def main(argv): | |||
| help="Debug build") | |||
| parser.add_argument("--parallel", "-j", type=int, default=0, | |||
| help="Number of parallel jobs during build") | |||
| parser.add_argument("--warn-error", action="store_true", | |||
There was a problem hiding this comment.
I'm not sure about making this true by default, that will be very annoying since the build isn't clean right now in many cases. And you can't expect everyone to go fix these.
There was a problem hiding this comment.
store_true means the default value is False, and when they add the --warn-error flag the value changes to True
There was a problem hiding this comment.
ah yes, never mind. been confused by that one before
|
The CI fail is not related, should I rebase to clear it? |
842175c to
05bed28
Compare
|
LGTM, merged. Thanks @mattip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the -Werror compiler option to build, build_clib and build_ext sub-commands. Can be used with
CC=clangto try out the clang compiler and see the errors