BLD, DOC: fix gh-14518, add release note #14568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommers
reviewed
Sep 22, 2019
af70d45 to
aa0f7f7
Compare
rgommers
approved these changes
Sep 22, 2019
|
Thanks Matti. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In gh-14518 we added a `--debug-configure`` option, but it didn't work. In one of the refactoring I made the option default value False when it should have been None.
Also added a release note for both gh-14518 and gh-14527. Manually added the second PR's tag line since towncrier will create the first one. Suggestions to improve the release note text are welcome