DOC: Document the NPY_SCALARKIND values as C variables. #14576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the ":c:data:" links could not resolve these because the values were not explicitly documented.
|
From my side this is ready for review. This should be rather straight-forward - if the change is desired. |
|
Thanks @MSeifert04. Note there is a tracking issue to try to turn on |
|
@mattip Thanks for the reference and for the review 👍 Does that mean I shouldn't address single instances and instead bulk-fix certain issues? I'm a bit confused :) |
|
between fixing all the 1090 remaining bad references in one go and fixing one letter typos is a wide range. This PR is a bit on the small side but OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the ":c:data:" links could not resolve these because the values were not explicitly documented.
Also removes some duplication with the doc of
PyArray_ScalarKind.Current documentation: https://numpy.org/devdocs/reference/c-api/array.html#c.NPY_SCALARKIND