-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
[WIP] Continue testing with new version of sphinx theme #14648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated the docs using and deployed using surge --project doc/source/build/ --domain generated-numpy-docs-28-sphinx2.surge.sh deployed at http://generated-numpy-docs-28-sphinx2.surge.sh |
@Shekharrajak Do you want to keep this open? |
I keep testing the new theme using this branch. So it must be open for now. |
It will be helpful if someone helps me resolving CI/CD failure. |
I think the warnings need resolving. For this one I think it's just doing what the warning says:
Here we want to be using MathJax instead of
This is configured in |
Thanks @rgommers ! Working on it. |
Finally all green 🎉 |
NEPs doc generated using |
latest devdoc after these changes : http://generated-numpy-docs-14648-sphinx2.surge.sh |
Looking at most pages on a 13" screen, the sidebar is shifting to below all content rather than on thee right side: For the reference guide pages on individual functions, the right sidebar is anyway empty: Should we get rid of the right sidebar? Other than that it looks quite good! I think we can upload this onto the doc server, which is nicer to test on than Surge. Then point more people at it:) |
I fixed this issue in new commit and build : http://generated-numpy-docs-14648-2-sphinx2.surge.sh/ |
New demo link after few fixes: http://generated-numpy-docs-14648-3-sphinx2.surge.sh/ |
Definitely an improvement. A few quick thoughts: When I click on a link, the page is aligned to the left-navbar's highlighted item rather than to the top of the page. Has the (left navbar site TOC) + (right navbar page TOC) concept been discussed? Traditionally I am used to the page TOC expanding out of the site TOC rather than appearing on a separate navbar. The top menu has a gap of white space between the logo and the "Quick Start" Maybe it is an artifact of using surge.sh, but the footer links are not correct. |
New generated numpy docs using the new commit from the scipy-sphiinx-theme : http://generated-numpy-docs-14648-5-sphinx2.surge.sh/ |
Yeah we have discussed it. I find that most of us don't really need the right sidebar. I think we should try to make the same in left sidebar itself. Thanks for the input and review. |
Ping all. Where does this stand these days? |
My guess is that we've decided to let pydata handle our theme, since their theme is nice enough and has enough interested maintainers to keep it afloat - meaning this can be closed. What theme is scipy using? |
That is also my recollection, I'll close this. Thanks @Shekharrajak. |
Continuation of #14494
Related PRs: https://github.com/Shekharrajak/scipy-sphinx-theme-v2/pull/42
Working copy: