Skip to content

MAINT: move numpy/random/examples -> numpy/random/_examples #14944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 20, 2019
Merged

MAINT: move numpy/random/examples -> numpy/random/_examples #14944

merged 2 commits into from
Nov 20, 2019

Conversation

mattip
Copy link
Member

@mattip mattip commented Nov 20, 2019

Move numpy/random/examples to numpy/random/_examples

See this comment, the files are not meant to be part of the public API.

@charris
Copy link
Member

charris commented Nov 20, 2019

Test failure looks legitimate.

@eric-wieser
Copy link
Member

Why does numpy/random/_examples/__init__.py exist at all, if these modules aren't support to be imported?

@mattip
Copy link
Member Author

mattip commented Nov 20, 2019

Why does numpy/random/_examples/init.py exist at all, if these modules aren't support to be imported?

Updated the docs and removed __init__.py

@charris charris merged commit d428127 into numpy:master Nov 20, 2019
@charris
Copy link
Member

charris commented Nov 20, 2019

Thanks Matti.

@mattip mattip deleted the move-examples branch November 2, 2020 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
03 - Maintenance 30 - API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattip @charris @eric-wieser