Fix for issue #1356 #15
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The underlying problem is that classes monkey-patched via new.instancemethod will only free memory correctly if they do _not_ implement the __del__ method, which is not the case for gzip.GzipFile. My proposed solution is to inherit from gzip.GzipFile and override relevant methods instead of monkey-patching.
|
Committed in f26fdc9 |
This was referenced Oct 19, 2012
bashtage
referenced
this pull request
in bashtage/numpy
May 16, 2019
ENH: Add closed generator to randint
fangerer
referenced
this pull request
in hpyproject/numpy-hpy
Jul 7, 2022
Merge in numpy-hpy from ss/array_array3 to labs-hpy-port * commit 'a197852c5099cec81ed8cdfde0a59a29316db2a3': hpy_raw_array_assign_scalar HPyArray_AssignRawScalar and HPyArray_EquivTypes
luyahan
pushed a commit
to plctlab/numpy
that referenced
this pull request
Apr 25, 2024
doc: Remove unused comments
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this fixes http://projects.scipy.org/numpy/ticket/1356