Skip to content

Conversation

pv
Copy link
Member

@pv pv commented Dec 4, 2019

Follow-up cleanup for gh-15021 and gh-15012. Add missing release note, pick up (most) recommendations from missed review, and fix a stray debug print.

@charris
Copy link
Member

charris commented Dec 4, 2019

The original is in 1.18.x as I wanted folks to have something to play with. Does this PR need a backport? I'll take the release note in any case.

@pv
Copy link
Member Author

pv commented Dec 4, 2019

I think none of these are crucial to backport.

Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Dec 4, 2019
@charris charris removed this from the 1.18.0 release milestone Dec 4, 2019
@seberg
Copy link
Member

seberg commented Dec 6, 2019

Thanks, lets put it in.

@seberg seberg merged commit abde0a7 into numpy:master Dec 6, 2019
@charris charris added the 09 - Backport-Candidate PRs tagged should be backported label Dec 14, 2019
@charris charris added this to the 1.18.0 release milestone Dec 14, 2019
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Dec 15, 2019
@charris charris removed this from the 1.18.0 release milestone Dec 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants