MAINT: resolve pyflake F403 'from module import *' used #15366
Conversation
353f1f7 to
6a109c5
Compare
|
not sure we need the extra comment |
There was a problem hiding this comment.
not sure we need the extra comment
# noqa: F403, but I guess it doesn't hurt and will make additional cleanup easier to find
For reference, see flake8's dcoumentation on "In-line Ignoring Errors". For any users of flake8, this message will normally be hidden for this line of code. It is also my mark to acknowledge and accept the use of from module import *, which is generally discouraged.
| @@ -14,7 +14,7 @@ | |||
| uses_accelerate_framework, get_sgemv_fix | |||
| ) | |||
| from numpy.compat import npy_load_module | |||
| from setup_common import * | |||
| from setup_common import * # noqa: F403 | |||
There was a problem hiding this comment.
For the record, I had difficulties making this into either a relative or absolute import. I can't recall exactly, but I think I tried from .setup_common import * and from numpy.core.setup_common import *, but both bombed Travis CI tests. If anyone knows why, I'd be interested.
* For external modules, resolve imported members * Most internal relative modules were ignored or marked noqa: F403 * Convert a few internal absolute imports to relative imports
|
Putting this in. I think we should limit the code churn simply to change relative/absolute imports. Both styles are commonly used, and it is not worth the effort to unify the code base. |
noqa: F403Found using:
the regular expression ignores internal relative imports