Skip to content

DEP: add PendingDeprecation to matlib.py funky namespace #15381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 27, 2020
Merged

DEP: add PendingDeprecation to matlib.py funky namespace #15381

merged 2 commits into from
Jan 27, 2020

Conversation

sethtroisi
Copy link
Contributor

Blame, the (FIXME: this makes little sense) note was added by @rgommers in 2019. "from numpy import *" has existed since ~2010. Hopefully this better explains why the * import is needed.

doc/source/reference/routines.matlib.rst is also available at https://docs.scipy.org/doc/numpy/reference/routines.matlib.html if that would be a better link

@sethtroisi sethtroisi changed the title Update comment DOC: Describe matlib.py funky namespace Jan 22, 2020
@eric-wieser
Copy link
Member

eric-wieser commented Jan 22, 2020 •
edited
Loading

We should probably stick a PendingDeprecationWarning for users who import this file (in a new PR, cc @mhvk who I think pushed through the original matrix deprecation)

@mhvk
Copy link
Contributor

mhvk commented Jan 22, 2020

Yes, makes sense to put the same warning as for matrix itself in here. And, indeed, I didn't even realize the purpose of this module when I did the get-all-matrix stuff together PRs!

@sethtroisi
Copy link
Contributor Author

@mhvk I'm happy to add the warning if you'd like.

@mwtoews mwtoews mentioned this pull request Jan 22, 2020
Merged
@mhvk
Copy link
Contributor

mhvk commented Jan 22, 2020

Sounds good to me, but I'll let @eric-wieser take charge (I've somewhat dropped out of numpy stuff)

@mattip
Copy link
Member

mattip commented Jan 23, 2020

Please add a DeprecationWarning, you can see the pattern in numpy/testing/utils.py

@sethtroisi
Copy link
Contributor Author

Wording taken from #10142

rgommers
rgommers previously requested changes Jan 23, 2020
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please note that deprecations should be discussed on the mailing list.

@rgommers rgommers changed the title DOC: Describe matlib.py funky namespace DEP: add PendingDeprecation to matlib.py funky namespace Jan 23, 2020
@rgommers rgommers dismissed their stale review January 23, 2020 12:47

Comment addressed

@sethtroisi sethtroisi force-pushed the matlib_namespace branch 2 times, most recently from 26bd5e7 to 4155213 Compare January 23, 2020 18:00
@eric-wieser
Copy link
Member

@rgommers happy to merge?

@rgommers
Copy link
Member

Yes, LGTM now, thanks

@mattip mattip merged commit ae5d911 into numpy:master Jan 27, 2020
@mattip
Copy link
Member

mattip commented Jan 27, 2020

Thanks @sethtroisi

@sethtroisi sethtroisi deleted the matlib_namespace branch January 27, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

@rgommers rgommers rgommers left review comments

Assignees
No one assigned
Labels
03 - Maintenance 07 - Deprecation component: numpy.matrixlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sethtroisi @eric-wieser @mhvk @mattip @rgommers