Relextrema #154
Closed
Relextrema #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add public functions relargmin and relargmax, which each call through to the non-public function _relargextrama. _relargextrama takes a comparator argument, and finds points for which comparator(x[n],x[n+i]) is true for i = +/-1,+/-2,...+/-order. relargmax uses the comparator numpy.greater, meaning this funtion will return the indices of those locations where x is larger than its `order` nearest neighbors.
…itted by mistake.
|
Hi Jacob, new additions like this should be discussed on the mailing list first. Can you please bring it up there? |
|
Sure. Sorry, wasn't sure about the etiquette. On Fri, Sep 9, 2011 at 13:04, Ralf Gommers <
|
|
Moved functionality to scipy, implemented more in-depth algorithm. See https://github.com/jsilter/scipy/tree/find_peaks. |
luyahan
pushed a commit
to plctlab/numpy
that referenced
this pull request
Apr 25, 2024
feat: Add vclt_[s8|s16|s32|f32|u8|u16|u32]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add argrelmin and argrelmax to lib/function_base.py
argrelmin and argrelmax are functions for finding the relative min and max of a set of data. Algorithm is to find points which are smaller (or larger) than their
ordernearest neighbors, whereorderis a parameter with a default value of 1. Both call through to _argrelextrama, which takes a comparison function as a parameter. Tests are included.