MAINT: Use the PyArrayScalar_VAL macro where possible #15426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we have this macro, we may as well use it. This changes all occurences except the Void ones, since there other fields that don't have accessor macros are also used.
|
Not my day today. Must be a typo here somewhere, will come back to it another day to try and find it. |
seberg
reviewed
Jan 24, 2020
Co-Authored-By: Sebastian Berg <sebastian@sipsolutions.net>
cielavenir
pushed a commit
to cielavenir/numpy
that referenced
this pull request
Aug 9, 2023
If we have this macro, we may as well use it. This changes all occurences except the Void ones, since there other fields that don't have accessor macros are also used.
cielavenir
pushed a commit
to cielavenir/numpy
that referenced
this pull request
Aug 22, 2023
If we have this macro, we may as well use it. This changes all occurences except the Void ones, since there other fields that don't have accessor macros are also used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have this macro, we may as well use it.
This changes all occurences except the Void ones, since there other fields that don't have accessor macros are also used.
Some more pre-#15385 cleanup