MAINT: Tidy macros in scalar_new #15441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seberg
reviewed
Jan 27, 2020
| #define _NPY_UNUSED1_0 | ||
| #define _NPY_UNUSED1_1 | ||
| #define _NPY_UNUSED1_2 NPY_UNUSED | ||
| #if @TYPE@_IS_OBJECT |
There was a problem hiding this comment.
I suppose these should be #if _@TYPE@_IS_OBJECT? (Was going to add defined first, but that is unnecessary I guess).
I think I like this style, although did not look through all yet. IIRC one thing that I was wondering if we cannot hardcode the result of PyTuple_GET_ITEM(cls.tp_bases, num)
eric-wieser
commented
Jan 27, 2020
Rather than trying to keep track of weird tri-state `@default@` and `@work@` variables, this uses a primitive dictionary with types as keys.
5971f8a to
a0ab69e
Compare
|
Thanks, the dance around |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than trying to keep track of weird tri-state
@default@and@work@variables, this uses a primitive dictionary with types as keys.@seberg, is this the type of cleanup you had in mind in #15393 (review)