Skip to content

TST: use manylinux2010 docker instead of ubuntu #15600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 19, 2020

Conversation

mattip
Copy link
Member

@mattip mattip commented Feb 18, 2020

xref MacPython/numpy-wheels#73

If we already are using a docker to test 32-bit linux, let's use the manylinux2010 one.

@mattip mattip force-pushed the multilinux2010 branch 5 times, most recently from 4eccbd6 to e995708 Compare February 18, 2020 22:10
@mattip
Copy link
Member Author

mattip commented Feb 18, 2020

This is now consistent with what I see locally when I use the docker to test. The failure fo sin is due to very large numbers escaping the AVX functions, and glibc's implementation is not consistent across platforms.

@charris
Copy link
Member

charris commented Feb 18, 2020

LGTM, I'll let you decide when to put it in due to the ongoing test fix.

@charris charris changed the title TST: use multilinux2010 docker instead of ubuntu TST: use manylinux2010 docker instead of ubuntu Feb 18, 2020
@mattip
Copy link
Member Author

mattip commented Feb 19, 2020

rebased on top of gh-15598

@mattip mattip merged commit f1a247f into numpy:master Feb 19, 2020
@mattip mattip deleted the multilinux2010 branch November 2, 2020 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants