-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
ENH: Provides a deep benchmark for universal functions #15992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
It seems the log output is now too large for travis, it exceeds 50,000 lines. Is there a way to tweak the benchmark run to be less verbose? |
@mattip, I guess the only way is by providing argument options to control of generated tests, same as in #15987, example |
It seems quite complicated. How will anyone track the changes over time when the full suite takes so long to run? What is the goal of the added benchmarks: perhaps there is another way to achieve the same goal. |
I was simply want to detect the performance changes, so I can reply to @rgommers comment. also for the upcoming patches.
simply you don't need to run all the tests only filter what u target through the regex.
ASV kinda slow even with disabling ASV's warmup process
This patch #15987 is more effective and faster. currently, I'm doing some final tests on it and |
Are you sure you cannot do what you wish with ASV and using your C code from gh-15987 (although that code looks fragile: what happens if we add more ufuncs)? |
There's no way to integrate the C code from gh-15987 since ASV doesn't provide a method to specify the elapsed time of each sample.
The python code still needs more improvements, but the C code looks good to me.
The python script collects all ufuncs via |
I still prefer this as an alternative to gh-15987. @seiko2plus do you now see a way to make the output nicer/less verbose? |
Provides a deep benchmark for universal functions.
This an alternative benchmark for #15987 based on
ASV
.