BUG: Fix bug in AVX complex absolute while processing array of mixed dtypes #16666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The 32 bit test failure looks legitimate. Maybe because windows x32 effectively uses a different FPU than x64. |
|
Providing a 1 ULP leeway and using Pythagorean triples to minimize the differences. |
|
LGTM. CI failures on s390x and python3.9 are not related. |
|
@r-devulap Could you make a PR against |
|
@charris will do. |
|
Thanks. |
|
Please see #16672 |
11 tasks
duncanmmacleod
added a commit
to duncanmmacleod/pycbc
that referenced
this pull request
Nov 11, 2020
the issue reported in numpy/numpy#16660 was fixed in numpy/numpy#16666 and released as part of numpy 1.19.1, so pycbc should now be able to use those newer versions, and just avoid 1.19.0
duncanmmacleod
added a commit
to duncanmmacleod/pycbc
that referenced
this pull request
Nov 20, 2020
the issue reported in numpy/numpy#16660 was fixed in numpy/numpy#16666 and released as part of numpy 1.19.1, so pycbc should now be able to use those newer versions, and just avoid 1.19.0
ahnitz
pushed a commit
to gwastro/pycbc
that referenced
this pull request
Nov 20, 2020
the issue reported in numpy/numpy#16660 was fixed in numpy/numpy#16666 and released as part of numpy 1.19.1, so pycbc should now be able to use those newer versions, and just avoid 1.19.0
OliverEdy
pushed a commit
to OliverEdy/pycbc
that referenced
this pull request
Apr 3, 2023
the issue reported in numpy/numpy#16660 was fixed in numpy/numpy#16666 and released as part of numpy 1.19.1, so pycbc should now be able to use those newer versions, and just avoid 1.19.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16660