Skip to content

DOC: Remove links for C codes #16896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 31, 2020
Merged

DOC: Remove links for C codes #16896

merged 3 commits into from
Jul 31, 2020

Conversation

takanori-pskq
Copy link

Related to #13114 and #16217 : separated from #16370 . :c:expr: is a new feature in sphinx 3, so it cannot be used here.

Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just want to make sure I have the context right - the changes here are largely related to #16370 (comment) right? i.e. c:expr was having problems parsing these? Did you try c:texpr as well?

Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having looked at this more, it does seem like all of the things that have been changed to inline literals make sense, and don't fit with any of the existing roles in the :c: domain, including the additions for sphinx 3.

@mattip mattip merged commit 210e542 into numpy:master Jul 31, 2020
@mattip
Copy link
Member

mattip commented Jul 31, 2020

Thanks @takanori-pskq

@takanori-pskq takanori-pskq deleted the i13114-5 branch July 31, 2020 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants