Skip to content

DOC: Fix the declarations of C fuctions #16897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2020
Merged

Conversation

takanori-pskq
Copy link

Related to #13114 . I referred to here for the arguments whose type cannot be specified, but I'm not sure this is the right way.

Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the changed references in array.rst are better fits for the c:macro:: name(arg list) signature that was added in sphinx 3.0. Instead of trying to add a signature to make this match the c:function:: directive, perhaps it's worth pushing this to the sphinx 3.0 cleanup (#16217) and using c:macro:: instead?

@takanori-pskq
Copy link
Author

Moved the macro-related changes to #16370 .

@mattip mattip merged commit 27cf59d into numpy:master Jul 31, 2020
@mattip
Copy link
Member

mattip commented Jul 31, 2020

Thanks @takanori-pskq

@takanori-pskq takanori-pskq deleted the i13114-6 branch July 31, 2020 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants