Add a test for data truncation when creating array from sequence of mixed numeric and string values #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixed numeric and string values
|
Thanks for the test, it has been added in master in 91f87e1. A bit sloppy that your name wasn't preserved as the author, apologies for that. It's best to always send a PR against master by the way. Nothing should be committed to maintenance branches directly, only backported. |
|
thouis, that was my fault that your name was left off. I did put in one of my branch commits, but all that got lost when the commits were squashed. I am new-ish to git, Ralf has shown me how to cherry pick so I won't make the same mistake in the future. Thanks for the test, and my apologies for not getting your name in correctly. |
luyahan
pushed a commit
to plctlab/numpy
that referenced
this pull request
Apr 25, 2024
feat: Add vshr[q]_n_[s8|s16|s32|s64|u8|u16|u32|u64]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a not-yet-resolved regression test for bug #1990. test_regression.py seemed like the most likely test suite to put the test into, as the bug was not present 1.5.1 (see post on numpy-discussion from Pierre Haesig)/.
The test is written such that either of the following fixes would cause the test to pass:
(for some reason, github won't let me specify the maintenance/1.6.x branch by name. I've filed it against the current 1.6.x hash.)