DOC: Fix the entries of C functions #17549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
Oct 13, 2020
eric-wieser
reviewed
Oct 13, 2020
eric-wieser
reviewed
Oct 13, 2020
| @@ -46,24 +46,26 @@ Floating point classification | |||
| corresponding single and extension precision macro are available with the | |||
| suffix F and L. | |||
|
|
|||
| .. c:function:: int npy_isnan(x) | |||
| .. c:var:: x | |||
There was a problem hiding this comment.
Also tempting to revert this change too, and save it for the main PR
eric-wieser
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #16217, #13114. Separated from #16370.
sphinx 2 doesn't support function-style macro, so basically used
functioninstead. When the type of parameter is unknown, I dealt with them in the same way asPyArray_MAX, PyArray_MIN, ...(doc/source/reference/c-api/array.rst, l.3476).