Skip to content

DOC: Modify Templates #17691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 4, 2020
Merged

Conversation

takanori-pskq
Copy link

For the comparison with #17515 . The differences are:

I think this is better than #17515, but I'm not sure.

Copy link
Member

@mattip mattip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@takanori-pskq in your opinion is this or PR gh-17515 preferable?

takanori-pskq and others added 4 commits November 4, 2020 19:56
Co-authored-by: Matti Picus <matti.picus@gmail.com>
Co-authored-by: Matti Picus <matti.picus@gmail.com>
Co-authored-by: Matti Picus <matti.picus@gmail.com>
Co-authored-by: Matti Picus <matti.picus@gmail.com>
@takanori-pskq
Copy link
Author

I think this PR (#17691 ) is a better way.

@mattip mattip merged commit b219f69 into numpy:master Nov 4, 2020
@mattip
Copy link
Member

mattip commented Nov 4, 2020

Thanks @takanori-pskq

@eric-wieser
Copy link
Member

Can you give a link to a description of this :: syntax?

@eric-wieser
Copy link
Member

eric-wieser commented Nov 5, 2020

Ah, I see it's at least implemented here:

https://github.com/sphinx-doc/sphinx/blob/master/sphinx/ext/autodoc/__init__.py#L54-L62

introduced in sphinx-doc/sphinx@dafb55a.

I get the feeling this is a sphinx implementation detail - that's not a problem, but if it blows up in our face hopefully someone will find this comment.

@takanori-pskq
Copy link
Author

I found this syntax in the document https://www.sphinx-doc.org/en/master/usage/extensions/autodoc.html .

As a hint to autodoc extension, you can put a :: separator in between module name and object name to let autodoc know the correct module name if it is ambiguous.

in the "Options and advanced usage" in the "Directive" section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants