Skip to content

MAINT, Benchmark: print the supported CPU features during the run of performance tests #17737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2021

Conversation

seiko2plus
Copy link
Member

print the supported CPU features during the run of performance tests

releated to #17736, #17716

@mattip
Copy link
Member

mattip commented Nov 9, 2020

The output of runtest.py, and now asv is getting quite verbose with this extra information. We need to find a better way to report it. Is there a way to add it to the json output of asv? Also, the function is not specific to running benchmarks so it would be nice to add it into the codebase in a more general way.

@seiko2plus
Copy link
Member Author

The output of runtest.py, and now asv is getting quite verbose with this extra information

I workaround it by implmenting ppid based lock.

We need to find a better way to report it. Is there a way to add it to the json output of asv?

unfortunately, I couldn't find any reference for such a case like this.

Also, the function is not specific to running benchmarks so it would be nice to add it into the codebase in a more general way.

I move it to lib/utils.

@mattip
Copy link
Member

mattip commented Nov 10, 2020

xref airspeed-velocity/asv#791 for adding metadata to the benchmark results.

Base automatically changed from master to main March 4, 2021 02:05
@charris
Copy link
Member

charris commented Apr 22, 2021

close/reopen

@charris charris closed this Apr 22, 2021
@charris charris reopened this Apr 22, 2021
@charris
Copy link
Member

charris commented Apr 22, 2021

@mattip Ping.

@charris
Copy link
Member

charris commented Apr 22, 2021

@seiko2plus Needs long line fixes.

@seiko2plus seiko2plus force-pushed the benchmark_simd_info branch from 4091f8e to 61a495e Compare April 22, 2021 21:24
@seiko2plus seiko2plus force-pushed the benchmark_simd_info branch from 61a495e to 523d70f Compare April 22, 2021 21:41
@seiko2plus seiko2plus force-pushed the benchmark_simd_info branch from 523d70f to 472b152 Compare April 22, 2021 21:58
@charris charris merged commit da6952f into numpy:main Apr 23, 2021
@charris
Copy link
Member

charris commented Apr 23, 2021

Thanks Sayed.

@rgommers rgommers added the component: SIMD Issues in SIMD (fast instruction sets) code or machinery label Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
03 - Maintenance component: SIMD Issues in SIMD (fast instruction sets) code or machinery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants