DOC, TST: avoid refcount semantics in using numpy.memmap #17754
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These test were very slow on PyPy and flaky on windows because they relied on refcount semantics to close the underlying
mmap
object when calling__del__
. This PR refactors them to useflush
instead, which is sufficient to prove the point of the tests. Alsoflush
to__del__
, and point out the shortfalls of__del__