Skip to content

DEP: undeprecate putmask. Used a lot, no need to deprecate it. #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

rgommers
Copy link
Member

No description provided.

@charris
Copy link
Member

charris commented Dec 28, 2011

Perhaps we could make it a suggestion instead? The advantages of the new function is that it is faster (I think), is more compatible with NA, and is stricter about casting. I think it would be an improvement and good preparation for the future. I suppose we could just just add the extra keywords to putmask as a workaround.

copyto(dst, src, casting='same_kind', where=None, preservena=False)

@rgommers
Copy link
Member Author

I am suggesting it in the docstring right? Do you want different wording, or something else? I don't understand why adding new keywords to putmask would help.

@charris
Copy link
Member

charris commented Dec 29, 2011

Might just add a mention of NA.. The preservena keyword of copyto keeps NA in the dst from being overwritten. But I agree that deprecating putmask is draconian and undeprecating it is the right thing to do.

@rgommers
Copy link
Member Author

Done.

@charris
Copy link
Member

charris commented Dec 31, 2011

I pushed this in 3d9bedb and opened enhancement ticket #2008 for implementing putmask with copyto.

@charris charris closed this Dec 31, 2011
luyahan pushed a commit to plctlab/numpy that referenced this pull request Apr 25, 2024
feat: Add vmls[q]_[s8|s16|s32|f32|u8|u16|u32]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants