Speedup the reduce method of the maximum minimum family of ufuncs. #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace assert with assert_. Cleanup trailing whitespace.
|
I went ahead and pushed this. |
This was referenced Oct 19, 2012
mattip
referenced
this pull request
in mattip/numpy
Mar 20, 2019
BLD: Add lm flag for non-windows platforms
fangerer
referenced
this pull request
in hpyproject/numpy-hpy
Jul 7, 2022
Merge in ~STEPAN.SINDELAR_ORACLE.COM/numpy-hpy from ss/array_array3 to labs-hpy-port * commit 'b38605ff84d4c2eaea59b03cc6948aafbe59fe35': array_add array_true_divide array_subtract Enough of array_power for the startup Partial port of array_power HPyNumericOps hpy_n_ops HPY_INPLACE_GIVE_UP_IF_NEEDED
luyahan
pushed a commit
to plctlab/numpy
that referenced
this pull request
Apr 25, 2024
feat: Add vbsl_s8
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These patches add reduce loop detection to the maximum/minimum/fmax/fmin ufuncs and then implement the nanmax and nanmin functions using fmax.reduce and fmin.reduce. Some tests have also been added/fixed.
The fmax and fmin reduce loops can be further speeded up by fixing things so that the isnan function call is avoided, but that is for another day.