DEP: deprecate np.testing.dec #18051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the decorators in np.testing.dec are intended for nose test framework support, deprecate them by updating the docstring and adding a warning when they are used on functions
For whatever reason the build system doesn't like the test calls to warnings.warn with no stacklevel parameter inside the tests that I moved.
|
This makes sense, it's about time. To be sure, can you please send an email to the numpy-discussion mailing list about this? All deprecations need to go through the mailing list for approval. |
|
I created a discussion on the mailing list for this pull request. |
|
@rpolley I am pretty sure we don't install nose for testing, so the moved tests were not actually run before this PR, and are not being run in it. Did you try it to make sure the deprecations work as advertised? |
I removed it from the CI testing while back, it used to be there. |
|
Checked locally, all looks good. |
|
Thanks @rpolley |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #17566 the decorators in
numpy.testing.decare intended for compatibility with the nose testing framework, and should discouraged in the documentation, if not outright deprecated. This pull request updates the documentation of these decorators with a deprecation warning telling people not to use the nose testing framework, adds a deprecation warning to them saying the same, and moves the tests tonumpy/core/tests/test_deprecated.pyand wraps them in an assert_deprecated check.Closes: #17566