Skip to content

BUG: fix np.ma.masked_where(copy=False) when input has no mask #18967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 10, 2021
Merged

BUG: fix np.ma.masked_where(copy=False) when input has no mask #18967

merged 3 commits into from
May 10, 2021

Conversation

constanzafierro
Copy link
Contributor

@constanzafierro constanzafierro commented May 9, 2021 •
edited by rgommers
Loading

Fixes #18946

Fixes np.ma.masked_where(copy=False), which before this patch failed to modify array in place when there were no masked elements in the array initially.

@rgommers rgommers added the component: numpy.ma masked arrays label May 9, 2021
@rgommers rgommers added this to the 1.21.0 release milestone May 10, 2021
@rgommers rgommers changed the title BUG: fixes np.ma.masked_where(copy=False) fails to modify array in place when there were no masked elements in the array initially BUG: fix np.ma.masked_where(copy=False) when input has no mask May 10, 2021
rgommers
rgommers approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice fix, thanks @cfierro94!

CI is all green, and bug fix and tests LGTM, so in it goes.

@rgommers rgommers merged commit b6eb3d8 into numpy:main May 10, 2021
@rgommers
Copy link
Member

Some very minor things for next time:

  • It's better not to merge main into the branch you are making the PR from (it makes the history more tangled), unless that's necessary to resolve a merge conflict.
  • I edited the title to be a bit shorter (easier to read in the list of open PRs), and moved the rest into the PR description.

pbrod pushed a commit to pbrod/numpy that referenced this pull request May 11, 2021
@constanzafierro @pbrod
BUG: fix np.ma.masked_where(copy=False) when input has no mask (numpy…
2a42ccb 
…#18967)

Fixes numpygh-18946
@constanzafierro constanzafierro deleted the mask-where-copy-issue-18946 branch May 16, 2021 17:55
@greglucas greglucas mentioned this pull request Jun 23, 2021
Merged
7 tasks
This was referenced Jun 24, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
00 - Bug component: numpy.ma masked arrays
Projects
None yet
Milestone
1.21.0 release
2 participants
@constanzafierro @rgommers