MAINT: Remove usage of the PEP 604 pipe operator #18985
Merged
+13
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the PEP 604 pipe operator and replace it with
typing.Union
.The pipe operator is currently not yet universally supported by all type checkers (see python/typeshed#4819).
While we don't necessarily have to wait for all type checkers to support it, I feel that delaying its usage to numpy 1.22
would still be a reasonable compromise.
Examples