NEP: Accept NEP 35 (like= keyword for array creation) as final
#19188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
like= keyword for array creation) as final
This accepts NEP 35 as final. There has been no discussion about it in a long time. The current mode is strict about type input (`like=` must be an array-like). So that most of the "open" points are OK to remain open. Unless we need to discuss the name `like` or the fact that we pass an array-like itself, the previously noted open points numpygh-17075 all seem not very relevant anymore.
|
Ping @pentschev, I don't think there was anything more necessary here, right? |
|
All good in the current form from my side. Thanks @seberg for putting this together! |
|
Thanks Sebastian. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This accepts NEP 35 as final. There has been no discussion about it
in a long time. The current mode is strict about type input
(
like=must be an array-like). So that most of the "open" pointsare OK to remain open.
Unless we need to discuss the name
likeor the fact that we passan array-like itself, the previously noted open points gh-17075
all seem not very relevant anymore.