TST: Ignore exp FP exceptions test for glibc ver < 2.17 #19209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BvB93
reviewed
Jun 9, 2021
h-vetinari
reviewed
Jun 10, 2021
numpy/core/tests/test_umath.py
Outdated
Comment on lines
999
to
1001
| # Older version of glibc may not raise the correct FP exceptions | ||
| # See: https://github.com/numpy/numpy/issues/19192 | ||
| if (get_glibc_version() >= 2.17): |
There was a problem hiding this comment.
Suggested change
| # Older version of glibc may not raise the correct FP exceptions | |
| # See: https://github.com/numpy/numpy/issues/19192 | |
| if (get_glibc_version() >= 2.17): | |
| # Older version of glibc may not raise the correct FP exceptions | |
| # See: https://github.com/numpy/numpy/issues/19192 | |
| # The check for ==0 is the fallback for non-glibc systems | |
| if (get_glibc_version() >= 2.17 or get_glibc_version() == 0): |
There was a problem hiding this comment.
Yup, fixed it. Works on windows now.
charris
reviewed
Jun 10, 2021
Sorry, I forgot a pretty important word while looking at this in a rush this morning 😅 |
hah, no problem, we've all got a lot of things going on ;)
of course :) |
charris
reviewed
Jun 11, 2021
|
Thanks @r-devulap . |
This was referenced Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19192