Skip to content

Revert "BUG: revise string_from_pyobj/try_pyarr_from_string with respect to malloc and copy." #19235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2021
Merged

Revert "BUG: revise string_from_pyobj/try_pyarr_from_string with respect to malloc and copy." #19235

merged 1 commit into from
Jun 13, 2021

Conversation

rgommers
Copy link
Member

Reverts #18759

See #18759 (comment) for details.

@rgommers rgommers requested a review from pearu June 13, 2021 13:09
@rgommers
Copy link
Member Author

Only failures are the lint jobs, which is expected. Since this is blocking the SciPy 1.7.0rc2 release (need the sdist job to stop crashing in scipy/scipy#14230), I'll merge it.

@rgommers rgommers merged commit 0cb9f7f into main Jun 13, 2021
@rgommers rgommers deleted the revert-18759-gh-18431-string_from_pyobj branch June 13, 2021 16:49
@rgommers rgommers mentioned this pull request Jun 13, 2021
Closed
@charris
Copy link
Member

charris commented Jun 13, 2021

Want me to trigger the nightly builds?

@rgommers
Copy link
Member Author

Yes please!

@rgommers
Copy link
Member Author

I forgot how that's done.

@charris
Copy link
Member

charris commented Jun 13, 2021

I forgot how that's done.

charris@fc [numpy-wheels.git (main)]$ git commit --allow-empty -m'Trigger build for NumPy SciPy fixes'
[main 51c6f4d] Trigger build for NumPy SciPy fixes
charris@fc [numpy-wheels.git (main)]$ git push upstream main

@pearu pearu mentioned this pull request Jun 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearu pearu Awaiting requested review from pearu

Assignees
No one assigned
Labels
component: numpy.f2py
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgommers @charris