NEP: Update NEP 47: Adopting the array API standard #19739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NEP has been updated and expanded to more accurately correspond to the implementation in numpy#18585, as well as various wording and grammar fixes.
asmeurer
commented
Aug 23, 2021
| library from NumPy. This was rejected because keeping it separate will make it | ||
| less likely for people to review it, and including it in NumPy itself as an | ||
| experimental submodule will make it easier for end users and library authors | ||
| who already depend on NumPy to access the implementation. |
There was a problem hiding this comment.
@rgommers I noticed the "alternatives" section was empty, so I added a small paragraph. Did I miss any other motivations for including the implementation in NumPy, or other alternatives?
|
Let's get this in. Thanks @asmeurer . |
|
Looks great to me, thank you @asmeurer ! |
|
Looks like I'm late to the party here - just read it, looks really good. Thanks Aaron! |
This was referenced Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NEP has been updated and expanded to more accurately correspond to the
implementation in #18585, as well as various wording and grammar fixes.
CC @rgommers @shoyer