MAINT: Misc np.array_api annotation fixes
#19969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BvB93
commented
Sep 27, 2021
Comment on lines
+38
to
+39
| _T = TypeVar("_T") | ||
| NestedSequence = Sequence[Sequence[_T]] |
There was a problem hiding this comment.
NestedSequence needs a free (subscriptable) parameter based on how it's used in np.array_api.asarray:
There was a problem hiding this comment.
Off topic: mypy has some basic support for recursive types these days,
so it is now possible to define a proper arbitrary-nested sequence type with the help of protocols (xref #19894)
np.array_api annotation fixes
|
These issues should also be mentioned at data-apis/array-api#143 |
This was referenced Sep 27, 2021
Changed as `Array` does not live in the main `np.array_api` namespace
|
I feel that the points that had to be addressed have now been addressed (including updates to the spec where needed). |
|
This looks good to me. |
|
Well, if Aaron thinks this is good, lets get it in. Thanks Bas! |
This was referenced Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping @asmeurer.
This PR introduces a number of minor annotation-related fixes to
np.array_api.The individual comments go into more detail regarding the nature of the various fixes.