MAINT: make sure CI stays on VS2019 unless changed explicitly #20579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #20524.
To avoid the deprecation warnings on azure for the old windows images, #20234 moved to windows-latest. This is currently equivalent to windows-2019 (bringing visual studio 2019, and corresponding toolset), but will presumably change to windows-2022 at some point in the future.
Such a change of compiler version should be made consciously for the numpy CI (rather than imposed by what azure does), because the compiler version used for windows effectively defines the lower bound of support on windows (as otherwise, changes that break on older compilers will not be caught in CI).