Skip to content

BUG: Fix array dimensions solver for multidimensional arguments in f2py #20721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 4, 2022
Merged

BUG: Fix array dimensions solver for multidimensional arguments in f2py #20721

merged 3 commits into from
Jan 4, 2022

Conversation

pearu
Copy link
Contributor

@pearu pearu commented Jan 3, 2022

Fixes #20709

@pearu pearu self-assigned this Jan 3, 2022
@pearu pearu requested a review from HaoZeke January 3, 2022 22:24
@pearu pearu added 06 - Regression 09 - Backport-Candidate PRs tagged should be backported labels Jan 3, 2022
HaoZeke
HaoZeke approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@HaoZeke HaoZeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pearu pearu requested a review from HaoZeke January 3, 2022 22:44
@pearu
Copy link
Contributor Author

pearu commented Jan 3, 2022

@HaoZeke , I have now added a test that reproduces the issue. Sorry for the early review request. The PR should be ready for final review now.

HaoZeke
HaoZeke approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@HaoZeke HaoZeke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test, seems good to go once the tests pass.

@pearu pearu merged commit 20f972c into numpy:main Jan 4, 2022
@pearu pearu deleted the gh20709 branch January 4, 2022 07:22
@charris charris mentioned this pull request Jan 4, 2022
Merged
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Jan 4, 2022
@HaoZeke HaoZeke mentioned this pull request Apr 19, 2022
Closed
This was referenced Jun 30, 2022
Open
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaoZeke HaoZeke HaoZeke approved these changes

Assignees

@pearu pearu

Labels
00 - Bug 06 - Regression component: numpy.f2py
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: [Regression 1.21.4 -> 1.22.0] f2py infers integers incorrectly from shape (-(nterms):nterms,nvcount)
3 participants
@pearu @HaoZeke @charris